Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor subscribe.css to SCSS #1867

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor subscribe.css to SCSS #1867

wants to merge 1 commit into from
+116 −134

Conversation

rohitsrma
Copy link

Description

This PR fixes a part of #896

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@welcome Welcome
Copy link

welcome bot commented Aug 14, 2024

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@netlify Netlify
Copy link

netlify bot commented Aug 14, 2024 •
edited
Loading

✅ Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 7f2bf4a
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/66bd0a788530190008f765df
😎 Deploy Preview https://deploy-preview-1867--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

leecalcote
leecalcote reviewed Aug 15, 2024
View reviewed changes
css/subscribe.scss
@@ -1,3 +1,6 @@
---
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, @rohitsrma.

Are these two lines intentional?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it tells Jekyll to process the file.

https://jekyllrb.com/docs/step-by-step/07-assets/

@Ashparshp
Copy link

@rohitsrma, Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

@stale Stale
Copy link

stale bot commented Sep 21, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/website issue/stale Issue has not had any activity for an extended period of time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohitsrma @Ashparshp @leecalcote